CCTC-team / redcap_cypress

REDCap Cypress Test Framework
MIT License
0 stars 0 forks source link

112. User Password Strategy #51

Open MintooXavier opened 3 months ago

MintooXavier commented 3 months ago

Brief description: Creating a user/resetting password, sends a email to inbox. This process needs to be tested manually.

User spec: https://github.com/CCTC-team/redcap_cypress/blob/redcap_val/user_requirement_specification/non_core/112_user_password_strategy.spec

Feature link: https://github.com/CCTC-team/redcap_cypress/blob/RY_v13.8.1/manual_scripts/User%20Password%20Strategy_112/D.112.100%20-%20User%20Password%20Strategy.feature

Pre review:

Post review:

rukayat-yakub commented 1 month ago

@MintooXavier Please review when you can

MintooXavier commented 1 month ago
  1. Please write the remaining steps. steps to enter password and submit: https://github.com/CCTC-team/redcap_cypress/blob/a55f232757b8ed5466e979698e3d602119b66fa5/manual_scripts/13_user_password_strategy.feature#L25
  2. No need to verify 2 Factor Authentication: https://github.com/CCTC-team/redcap_cypress/blob/a55f232757b8ed5466e979698e3d602119b66fa5/manual_scripts/13_user_password_strategy.feature#L51
  3. Each time you set/reset the password, verify you can login with the password.

@rukayat-yakub Review completed

rukayat-yakub commented 1 month ago

@MintooXavier - Done

MintooXavier commented 1 month ago

Please create a folder (as mentioned previously) for each feature inside manual_scripts and put the scripts in it. The naming convention would be Data_Resolution_Workflow_106 where 106 is the feature number.

rukayat-yakub commented 1 month ago

@MintooXavier -Done

MintooXavier commented 1 month ago
  1. Change Test to User: https://github.com/CCTC-team/redcap_cypress/blob/811324be6342ec25a5ca6826cc92cb3a9157de7a/manual_scripts/User_Password_Strategy_112/D.112.100_user_password_strategy.feature#L18
  2. Change VERIFY_DE: to VERIFY, not sure what DE is, might be Data Entry. https://github.com/CCTC-team/redcap_cypress/blob/811324be6342ec25a5ca6826cc92cb3a9157de7a/manual_scripts/User_Password_Strategy_112/D.112.100_user_password_strategy.feature#L21
  3. Add a step 'Given I open Email'. There is no actual step for it now, so will have a squiggly line. I have added the step definition to my branch. Will be adding it to redcap_val later when we automate these tests.
  4. Password not tested here. This was mentioned in the previous review. https://github.com/CCTC-team/redcap_cypress/blob/811324be6342ec25a5ca6826cc92cb3a9157de7a/manual_scripts/User_Password_Strategy_112/D.112.100_user_password_strategy.feature#L31
  5. Login before this line. Write step- 'Given I visit the REDCap login page'. Then enter username and password and login. https://github.com/CCTC-team/redcap_cypress/blob/811324be6342ec25a5ca6826cc92cb3a9157de7a/manual_scripts/User_Password_Strategy_112/D.112.100_user_password_strategy.feature#L34
  6. This is a link. https://github.com/CCTC-team/redcap_cypress/blob/811324be6342ec25a5ca6826cc92cb3a9157de7a/manual_scripts/User_Password_Strategy_112/D.112.100_user_password_strategy.feature#L34
  7. Similarly changes also occur in the code below. Please change it. Check you visit the redcap login page (or open email) before you start cliking on the links
rukayat-yakub commented 1 month ago

@MintooXavier Please review when you can. Please check to see the correct numbering it is missing 11 in the manual_scripts

MintooXavier commented 4 weeks ago

Script 11 (Field Embedding) is merged with Action Tags. Check script 107.

MintooXavier commented 4 weeks ago
  1. Below two steps are not in data entry forms. Use 'I enter "" into the input field labeled ""' https://github.com/CCTC-team/redcap_cypress/blob/e8b4ffedadda77af9e9599deddcda99cd35280da/manual_scripts/User%20Password%20Strategy_112/D.112.100%20-%20User%20Password%20Strategy.feature#L28. Similarly change everywhere.
  2. Lines 38 to 44 can be deleted as you are logging out and logging back in again. Leave the comments in but delete Gherkin.
  3. After this, add 'Then I should see "EMAIL SENT!"' https://github.com/CCTC-team/redcap_cypress/blob/e8b4ffedadda77af9e9599deddcda99cd35280da/manual_scripts/User%20Password%20Strategy_112/D.112.100%20-%20User%20Password%20Strategy.feature#L65

@Rukayat - Code review completed.

rukayat-yakub commented 4 weeks ago

@MintooXavier - I have made the corrections

MintooXavier commented 4 weeks ago

Script reviewed and passed