search

CCTC-team / redcap_cypress

REDCap Cypress Test Framework
MIT License
0 stars 0 forks source link

18. Data Quality #59

Open MintooXavier opened 5 months ago

MintooXavier commented 5 months ago

Brief description: This feature is used to add validations in a project.

User spec: https://github.com/CCTC-team/redcap_cypress/blob/redcap_val/user_requirement_specification/core/18_data_quality.spec

Feature link: https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.100%20-%20Data%20Quality%20default%20rules.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.200%20-%20Data%20Quality%20create%20rules.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.300%20-%20Data%20Quality%20execute%20rules.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.400%20-%20REDUNDANT.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.500%20-%20Data%20Quality%20disrepancies.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.600%20-%20Data%20Quality%20exclude%20rules.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.700%20-%20Data%20Quality%20edit%20rules.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.800%20-%20REDUNDANT.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.900%20-%20REDUNDANT.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.1000%20-%20Data%20Quality%20realtime.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.1100%20-%20REDUNDANT.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.1200%20-%20REDUNDANT.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.1300%20-%20Data%20Quality%20DAG.feature https://github.com/CCTC-team/redcap_rsvc/blob/redcap_val/Feature%20Tests/C/Data%20Quality_18/C.4.18.1400%20-%20Data%20Quality%20support%20user%20rights.feature

Pre review:

Post review:

MintooXavier commented 5 months ago
  1. C.4.18.1100 - The system shall support validating the unique event name used in custom rules for longitudinal projects. Script says 'This feature test is REDUNDANT and can be viewed in C.4.18.200.100' but it is not tested in it. I enquired about this and Theresa Baker modified the script C.4.18.200.100 to add event name but this is in v 14.3.4

C.4.18.200 - Data Quality create rules.feature

Emailed REDCap Team - Theresa Baker and Adam De Fouw regarding the above script:

  1. C.4.18.700 – Data Quality edit rules
    • Added step to check ‘Execute button is not visible’

Modified both the scripts and pushed to MX_v13.1.37

MintooXavier commented 3 months ago

ATS team accepted the changes

MintooXavier commented 3 months ago

Scripts Pre-reviewed:

  1. C.4.18.100 - Data Quality default rules
  2. C.4.18.200 - Data Quality create rules
  3. C.4.18.300 - Data Quality execute rules
  4. C.4.18.400 - REDUNDANT
  5. C.4.18.500 - Data Quality disrepancies
  6. C.4.18.600 - Data Quality exclude rules
  7. C.4.18.700 - Data Quality edit rules
  8. C.4.18.800 - REDUNDANT
  9. C.4.18.900 - REDUNDANT
  10. C.4.18.1000 - Data Quality realtime
  11. C.4.18.1100 - REDUNDANT
  12. C.4.18.1200 - REDUNDANT
  13. C.4.18.1300 - Data Quality DAG - Assign user rights twice else doesn't work for me. In branch MX_v13.8.1
  14. C.4.18.1400 - Data Quality support user rights - Assign user rights twice else doesn't work for me. In branch MX_v13.8.1

All scripts pass

MintooXavier commented 3 months ago

C.4.18.100 - Data Quality default rules.feature

C.4.18.600 - Data Quality exclude rules