CCTC-team / redcap_cypress

REDCap Cypress Test Framework
MIT License
0 stars 0 forks source link

110. Special Functions #70

Open MintooXavier opened 1 month ago

MintooXavier commented 1 month ago

Brief description: List of functions that can be used in Branching Logic, Calculations, Report filtering, Data Quality Module, Automated Survey Invitations, etc.

User spec: https://github.com/CCTC-team/redcap_cypress/blob/redcap_val/user_requirement_specification/non_core/110_special_functions.spec

Feature link: https://github.com/CCTC-team/redcap_cypress/blob/TA_v13.8.1/manual_scripts/Special%20Functions_110/D.110.100%20-%20Special%20Functions.feature

Pre review:

Post review:

TanDBPRO commented 1 month ago

@MintooXavier - Please review script when you have time.

MintooXavier commented 1 month ago
  1. https://github.com/CCTC-team/redcap_cypress/blob/45b170c23775e1be2bcd486cba7b7161ea4cfdbd/manual_scripts/D.110.100_Special_Functions.feature#L22 - check name
  2. https://github.com/CCTC-team/redcap_cypress/blob/45b170c23775e1be2bcd486cba7b7161ea4cfdbd/manual_scripts/D.110.100_Special_Functions.feature#L89 - value for weight and height are alreay present. Before you add the special function for bmi_suitable, when entering data for weight and height, verify BMI suitable for study = 0
  3. https://github.com/CCTC-team/redcap_cypress/blob/45b170c23775e1be2bcd486cba7b7161ea4cfdbd/manual_scripts/D.110.100_Special_Functions.feature#L19 - change to 'Add datediff special function', similarly for others
  4. https://github.com/CCTC-team/redcap_cypress/blob/45b170c23775e1be2bcd486cba7b7161ea4cfdbd/manual_scripts/D.110.100_Special_Functions.feature#L32 - Test datediff special function, similarly for others
  5. https://github.com/CCTC-team/redcap_cypress/blob/45b170c23775e1be2bcd486cba7b7161ea4cfdbd/manual_scripts/D.110.100_Special_Functions.feature#L41 - simply put #VERIFY, no need any comments
  6. https://github.com/CCTC-team/redcap_cypress/blob/45b170c23775e1be2bcd486cba7b7161ea4cfdbd/manual_scripts/D.110.100_Special_Functions.feature#L139 - check name
  7. Before adding the special function, verify the field is empty or 0 - for all the 5 functions

@TanDBPRO : Pre-review completed.

TanDBPRO commented 1 week ago

@MintooXavier - Please review when you can. I made the changes you have advised above.