search

CCirbo / Little_Shop

1 stars 2 forks source link

Feat: adds the serializer for merchant, added initial test for index … #36

Closed CCirbo closed 3 weeks ago

CCirbo commented 3 weeks ago

This PR adds Serializer-merchant initial merchant request test merchant route index merchant controller index serializer gem request test file merchant

MDelarosa1993 commented 3 weeks ago

Looks good to me! I see that you’ve cleaned up the Gemfile and fixed the model associations. The added RSpec tests will definitely help catch any issues with relationships. Thanks for updating the FactoryBot setup too. Everything seems in order

jimmacur commented 3 weeks ago

The index on the merchant controller is looking very clean! Also, thanks for adding the serializer.