Added test, route and action method to get all items

CCirbo / Little_Shop

1 stars 2 forks source link

Added test, route and action method to get all items #47

Closed MDelarosa1993 closed 3 weeks ago

MDelarosa1993 commented 3 weeks ago

Add Items API Endpoint and Corresponding Tests

Controller Update: Implemented index action in Api::V1::ItemsController to return a list of items serialized by ItemSerializer.
Routes Update: Added route for fetching items at /api/v1/items.
Tests: Added request specs for items endpoint, including creating test data and validating JSON response structure and content.

jimmacur commented 3 weeks ago

Great addition! The implementation of the index action in Api::V1::ItemsController and the corresponding route setup looks good. The new test suite in items_requests_spec.rb effectively covers the key attributes of the Item model and validates the response structure. Also, I appreciate the updates to the merchants_requests_spec.rb file for consistency. Everything seems well-organized and functional.

CCirbo commented 3 weeks ago

Looks good overall. The index action is straightforward, and I like how the ItemSerializer handles the response. The route is clean, and the request specs cover what they need to—solid coverage on both data creation and response validation. Nicely done on keeping things well-tested.