search

CCirbo / Little_Shop

1 stars 2 forks source link

Fix: debugged problems #61

Closed CCirbo closed 3 weeks ago

CCirbo commented 3 weeks ago

Had some debugging issues, this PR fixes that, now all tests are passing again and Postman is also working.

MDelarosa1993 commented 3 weeks ago

Great work on this PR! Here are a few notes:

Controller Updates: I noticed you've refactored the MerchantsController to streamline the index method and handle sorting/filtering more effectively. The removal of redundant code is definitely a step in the right direction.

Model Improvements: The changes in the Merchant model for sorting and filtering look solid. The updated methods are clearer and should improve performance.

Tests: The adjustments to the test cases are well-done, particularly in aligning them with the new logic in the controller and model. The fixed assertions make the tests more reliable.

Overall, the updates improve both the functionality and readability of the code. Nice job!

jimmacur commented 3 weeks ago

Agreed with Melchor. There were a lot of conflicts you resolve. Nice work!!! There are some comments we can get rid of in a code cleanup party!!!