Fix merchant model methods

CCirbo / Little_Shop

1 stars 2 forks source link

Fix merchant model methods #66

Closed litobot closed 3 weeks ago

litobot commented 3 weeks ago

Repair all duplication conflicts with Melchor's methods
Added/modified existing model methods (100% coverage - all passing)
Added item_count to json via MerchantSerializer
Ran into some problems with matching the Postman Scripts but I fixed it.

MDelarosa1993 commented 3 weeks ago

Thanks for the update! I appreciate the thorough resolution of duplication conflicts and the enhancement to the MerchantSerializer. Good to hear the Postman script issues are resolved and everything is covered with tests.

jimmacur commented 3 weeks ago

Thanks for the hefty pull request! I appreciate the updates to the MerchantsController and the new sort_and_filter method in the Merchant model. The addition of the item_count attribute in the serializer is a nice touch too! I'll echo Melchor in saying nice work on merging two two similar code blocks.

Thanks again!