search

CCirbo / Little_Shop

1 stars 2 forks source link

Feature/delete an item clean #70

Closed TDManning closed 3 weeks ago

TDManning commented 3 weeks ago

This includes a refactor or the merchant delete test and adds code for creating an item and its associated resources.

jimmacur commented 3 weeks ago

The additions to both the item and merchant deletion functionality look great. The expanded test coverage also adds confidence that this logic is functioning as expected. Nice work on handling edge cases, such as the appropriate status codes and ensuring all dependent records are accounted for. And, thanks for cleaning up the files as you go along.

CCirbo commented 3 weeks ago

Thanks for the updates! Everything looks solid, especially with the route addition and the destroy method in the ItemsController. Just a quick question—are we handling the case where the item doesn’t exist in the controller? Might be good to ensure we’re returning the appropriate error response. The test updates seem comprehensive, but maybe we could add a test for that edge case as well.

Great job overall!