CCirbo / Little_Shop

1 stars 2 forks source link

Fix missing coverage in items_controller #98

Closed litobot closed 3 weeks ago

litobot commented 3 weeks ago

This PR addressed the gaps in coverage regarding the un-RESTful route in the items_controller. Many tests were required in order to fully cover every possible combination of search queries passed into this un-RESTful route.

I also removed redundant code in the item.rb file.

I'm just realizing we can remove some comments, but that can happen as a final refactor.

Screenshot 2024-09-16 at 8 56 42 PM

jimmacur commented 3 weeks ago

Testing is looking great! I love the descriptions of the test items :) Nice work getting all lines covered in simplecov!

CCirbo commented 3 weeks ago

Extremely thorough testing, love it!!