CD4017BE / InductiveLogistics

Partial follow up to my Minecraft-mod InductiveAutomation, containing only the item & fluid transport, sorting, storage, etc. features
MIT License
5 stars 3 forks source link

Fluid Pipes do not extract fluids from Immersive Petroleum distillation towers #23

Closed BenB196 closed 6 years ago

BenB196 commented 6 years ago

What I did:

Description of your setup (how devices where configured, connected etc.) and what you did (eventually a screenshot) I attached a fluid extraction pipe to an Immersive Engineering distillation tower and a Fluid inject pipe (with a filter, taking off the filter did not fix it) to the tank. With an advanced universal pipe connecting them.

pipe_setup

Side note: a standard fluid pipe gets the fluid automatically, but does not actually connect to the tower output for some reason.

What happened:

Description of what happened, how things behaved and/or crash report (if any) or log entries (only the relevant parts if any) The fluids in the tower did not go anywhere, and the pipes would not move any fluid.

What should have happened:

The behavior you expected or would like to have (obsolete for crashes) The pipes should extract and transport the fluids to the tank.

Used Versions:

BenB196 commented 6 years ago

I believe I found the issue, but want to confirm that it is working correctly. It looks like only Fluid Destination pipes work now, and fluid inject pipes do not, is this intended?

CD4017BE commented 6 years ago

The Advanced Universal Pipes got some new connection types added recently. The previous purpose of injection pipes is now handled by destination pipes. And the injection pipes now work as active retrievers instead, pulling items/fluids from source pipes. Extraction and injection pipes are the ones that actively supply or drain their connected tank, whereas the destination and source pipes are considered passive, they just mark the targets to get or put things. In general things can only move between active <-> passive connection but not passive -> passive or active -> active.

About the problem with the normal pipes: I also recently noticed them disconnecting from Immersive Multiblocks after chunk unloads. I think it may be that sometimes in the first tick after chunk load where the pipe does its logic to connect with neighboring devices, the multiblock structure might not have its inventory/tank capabilities ready to that point, so the pipe assumes it can't connect to it. Giving it a block update should make it recheck and fix it.

CD4017BE commented 6 years ago

Maybe I could fix this bug by performing the after load checks via the single tick schedule system in my library since that runs on Forge Game Tick Events that are performed after the main world tick. So this could give the Immersive multiblock structure time do to its initialization stuff first.