CD4017BE / InductiveLogistics

Partial follow up to my Minecraft-mod InductiveAutomation, containing only the item & fluid transport, sorting, storage, etc. features
MIT License
5 stars 3 forks source link

Item Injection pipes do not take advantage of the dual input slots from IC2's Induction Furnace #8

Open flamechair opened 6 years ago

flamechair commented 6 years ago

Hi there,

I'm a big fan of your mod and have been using it on my server. When creating an ore processing pipeline, I noticed that items injected into the top of an IC2 Induction Furnace only fills one slot, despite the Induction Furnace having two available. I think it would make sense if the Inductive Logistics pipes would be able to take advantage of both Induction Furnace slots.

CD4017BE commented 6 years ago

Since IC2 is a pretty old mod, I assume that their machines are still using the old vanilla inventory system whereas nowadays mods (including mine) usually work with Forge's ItemHandler capabilities. So in order to make their machines still work with current mods they probably use some kind of wrapper to make the inventory available as capability too and for the Induction Furnace they just forgot to include the second input slot. However this is just my hypothesis, in order to proof it, please take a Portable Inventory Remote and link it to the top of the Induction Furnace (by sneak right click) and then open its GUI (by right click in air) and tell me:

flamechair commented 6 years ago

Hi,

I did as you asked and I was able to link them. It shows 7 total inventory slots in the Portable Inventory Remote and I am able to insert blocks into 2 of the 7, and the blocks are transferred to both input slots of the induction furnace. The other 5 slots are probably for the 2 output slots, 2 upgrade slots, and 1 power source slot:

Remote Inventory: 2018-01-06_17 28 04

Induction Furnace: 2018-01-06_17 28 39

CD4017BE commented 6 years ago

When testing the whole thing on a "fake Induction Furnace inventory" (which from the perspective of the pipe code should be indistinguishable from a real Induction Furnace) the pipes work correctly and fill both slots. 2018-01-13_20 18 42

That your insertion works with the remote tool but not with pipes was weird to me first but then I realized the the remote tool (unlike the pipe) isn't performing simulated insertions before the actual insertion, it just directly tries to insert the stack. So its still possible that only IC2's handling of simulated insertions is buggy.

So for the final test verify that it's actually IC2's fault do the following: Put 2 stacks cobble into your inventory and try to insert them with the remote tool again but this time click on the slot in the remote inventory GUI while holding shift. Try this on both slots and with different stack sizes. Normally if you insert a stack < 64 it should automatically take some additional items from your inventory to fill the slot up to 64.