Unittests always reported as passed

CDAT / cdat

Community Data Analysis Tools

Other

174 stars 68 forks source link

Unittests always reported as passed #1015

Open jbeezley opened 9 years ago

jbeezley commented 9 years ago

Many of the unittests in UV-CDAT are broken because ctest will always report passed even when it actually fails. For example, see here. This happens because the exit code is never set for these tests. Either the tests need to use unittest.main, which will set the status automatically, or get the results via TestResult.wasSucessful.

alliepiper commented 9 years ago

Just making a note of this here, since it's related to this issue and doesn't have its own:

https://github.com/UV-CDAT/uvcdat/blob/be51764d9d410e114ee6011b59338946fad925ee/testing/dv3d/TestManager.py#L142

Missing baselines should be a failure.

jbeezley commented 8 years ago

Bumping this again as I noticed most tests inside testing/regrid (~55 of 65) and testing/cdms2 (~20 of 45) don't set exit statuses when they fail.