Open doutriaux1 opened 8 years ago
@danlipsa the diff is in branch fix_Autot
can you reproduce?
@doutriaux1 On linux adding x.setbgoutputdimensions(xSize,ySize) after vcs.init results in X Error of failed request: BadAlloc (insufficient resources for operation) Major opcode of failed request: 53 (X_CreatePixmap) Serial number of failed request: 29 Current serial number in output stream: 31 So, this does not seem to have anything to do with autot or VTK.
I would think doing any plot with these to set would result in a similar crash.
@danlipsa yes there are two issues here 1- you didn't set an output dimension to your tests png so they were different on different machines and that led to the tests failing 2- I tried to fix 1- by setbgoutputdimensions and now it seg fault. NOt sure if that is a VTK or vcs issue.
No, I set the size at the beginning of the file: 800 by 400 (or 400 by 800). I think the problem is in foreground mode, when the window is resized by the OS and ends up a different size. I had to reduce the resolution when moving from my desktop to my laptop, but I did not look very closely at it. Try 600 by 300. If that works on your laptop, we can move on and look at this issue latter.
@doutriaux1 I reduced the size of the image to make it 250 x 500 and reenabled the autot tests. Could you test those on you mac. https://github.com/UV-CDAT/uvcdat/pull/1967
@danlipsa will look into it.
@doutriaux1 @aashish24 The problem here is: x.setbgoutputdimensions(1620, 1080) this function has the default units 'inches' so this results in setting the resolution 116640x77760 pixels. Understandably, on linux X reports: BadAlloc (insufficient resources for operation). We cannot do much about mac crashing. :smile: So, I'll close this once I get the go ahead from you guys.
I don't understand. Didn't we use that for years and always ended up with the correct (in pixels) size for our baselines? Did this change recently? Anyhow I would say let's make it pixels by default.
Maybe this API is more for the physical size of the output - at least this is what the documentation suggests. It has examples for output being US Legal and A4.. You can specify the size of the screen/off-screen buffer as the geometry parameter to init. So I would propose to leave it as it is and close this Issue.
Other defaults: vcs.png: units=None - > I think this results in pixels vcs.pdf: units='inches' vcs.svg: units='inches' vcs.postcript: units='inches'
@aashish24 Do you have any input on this?
@danlipsa like @doutriaux1 I am curious too. For testing we set the bg dimensions and I thought they are in pixels since the resultant image seems to be of correct size. My question is why we get right size on my machine if the unit is set to inches. I apologize if you already explain it but I couldn't find the clear answer for this question.
@doutriaux1 @aashish24 grepping for this function shows that everywhere it is used has units='pixels' parameter added. Also the default value for the parameter units='inches' goes back at least to bb62d26fb8ac8caee83bd23bc0993347d85d0c59 which is Dec 29 2011. The repo goes back to 29 10:06:12 2010 and the function did not exist then.
We fix this by deprecating setbgoutputdimensions() and removing bgX and bgY.
running script:
apple bug report: