Fixes error messages #409

jasonb5 commented 3 years ago

Fixes opening non-existent files will now raise FileNotFoundError.
Fixes Cdunif.CdunfiError.
Fixes raising CdunifError in Cdunif module, previously this was an OSError, which made node sense.
Fixes propagating errors from libcdms to Cdunif module, alot of errors would be raised as "No Error"
Fixes nested errors when opening files. This would occur if something failed while opening a file and would result in both an OSError and CDMSError being raised, creating a very confusing stacktrace. This will now raise a CdunifError.

muryanto1 commented 3 years ago

@jasonb5 Hi Jason, can you update last_stable to be 3.1.5 in the Makefile?

jasonb5 commented 3 years ago

@muryanto1 sure thing, i'm not sure when i'll be ready to merge this. I need to figure something out for CdunifError as this is currently API breaking and i'd like to find a different solution.

jasonb5 commented 3 years ago

I brought the CDMSError into the c layer so we could use it as a base for CdunifError. This should prevent breaking the API when raising the new CdunifError when open fails.

jasonb5 commented 3 years ago

Ah good point, I should probably remove it.

CDAT / cdms

Fixes error messages #409 #412