search

CDAT / cdtime

climate calendar manipulation tools
0 stars 2 forks source link

Mingle python 2 and 3 with ifdef #19

Closed dnadeau4 closed 6 years ago

doutriaux1 commented 6 years ago

@dnadeau4 this looks great. Thanks! In the test . I think we need to add some tests for comp<rel rel<comp etc...

dnadeau4 commented 6 years ago

@doutriaux1 please merge.

doutriaux1 commented 6 years ago

@dnadeau4 please make sure we had tests for comptime vs reltime etc... as requested in my review. It's important to make sure this works.

dnadeau4 commented 6 years ago

Can you make another issue for the tests? This bug is solved.
I did add a test between comptime vs reltime using == as you wanted.

doutriaux1 commented 6 years ago

I'll add the tests myself when I get to this... Hopefully tomorrow... I would rather the branch to be complete before merging in.

dnadeau4 commented 6 years ago

@doutriaux1 can you merge?

doutriaux1 commented 6 years ago

I still need to add the test. Can this wait just another day?

doutriaux1 commented 6 years ago

@dnadeau4 good thing I checked and added tests. My new tests fail. Back to to drawing board 😢