CDAT / ci-bots

Automated Test Suite Tools for MPAS
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Unverified HTTPS request (potential problem?) #12

Open pwolfram opened 7 years ago

pwolfram commented 7 years ago

Is this warning an issue that needs to be addressed?

/ccs/proj/cli115/pwolfram/anaconda_envs/default-2.7/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py:852: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)
pwolfram commented 7 years ago

Note, behavior is as expected (no known bug) but I'm not sure if this is something we need to get out in front of to avoid a problem in the future.

pwolfram commented 7 years ago

Example use where warning was encountered: https://github.com/MPAS-Dev/MPAS-Analysis/pull/227#pullrequestreview-56352834

doutriaux1 commented 7 years ago

I can have it on/off. It's an issue with the lab certificate not being accepted so I turned it off. I can't try to have it on/off as an option.

pwolfram commented 7 years ago

Gotcha-- should we intentionally suppress this warning, making just a comment to this effect in the code as to why this was done?