CDAT / jupyter-vcdat

A Jupyter Lab extension based on vCDAT.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Rename variable #114

Closed downiec closed 5 years ago

downiec commented 5 years ago

This is a large PR that contains several important changes in order to make renaming/copying of variables functional (issue #49):

doutriaux1 commented 5 years ago

@downiec tests are failing, I sshed into the machine and import cdms2 works, so it's a real failure

downiec commented 5 years ago

@doutriaux1 I will try to find out what is failing. As far as the rename variables button.. removing a click means the user won't have a chance to confirm their choice and get the feedback message if there are issues. I can look into alternatives but I think it would be good to get user feedback first because some people might prefer to have the button so they can 'confirm' their choice. I understand what you mean though as I also forgot to push the button sometimes (mainly because I was just in a hurry testing things).

downiec commented 5 years ago

@doutriaux1 I think I know what the failure is. I changed the name of the 'axis' button, to 'edit' so the selenium test couldn't find the slider button.