search

CDAT / jupyter-vcdat

A Jupyter Lab extension based on vCDAT.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Closing a notebook will cause an error popup #129

Closed sterlingbaldwin closed 5 years ago

sterlingbaldwin commented 5 years ago

Describe the bug closing a notebook will cause the message "ERROR: this.layout is null" to pop up.

To Reproduce Steps to reproduce the behavior:

  1. Open a variable, plot someting
  2. Close the notebook
  3. See error

Expected behavior There should be no errors when closing a notebook

Screenshots

Screen Shot 2019-06-13 at 11 42 09 AM

Desktop (please complete the following information):

downiec commented 5 years ago

I'm having difficulty reproducing this error. I tried the following: Open a clt.nc file (wait for load) Select variable 'clt' Plot variable Close notebook

Each time I tried I couldn't get the error to popup.

sterlingbaldwin commented 5 years ago

I think it might actually have been a jupyter issue, since I dont think we mess with the layout at all. I'll try it with the new juypter 1.0 and see if its still a problem.

downiec commented 5 years ago

Yeah that might be it, I've been trying to reproduce it with Jupyterlab 1.0

downiec commented 5 years ago

I will close this issue and we can reopen it if it ever surfaces again.