search

CDAT / jupyter-vcdat

A Jupyter Lab extension based on vCDAT.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Variable loading UI lag #133

Closed sterlingbaldwin closed 5 years ago

sterlingbaldwin commented 5 years ago

Describe the bug After selecting a variable to load, the loading code is injected, and all the info in the varLoader modal is wiped clear, but the modal doesnt actually close until the loading cell completes. This process can take several-to-many seconds depending on the size of the data, and since the varLoader is wiped clean there's no reason for it to continue to be displayed.

To Reproduce Steps to reproduce the behavior:

  1. Click "load variable"
  2. Click on a variable
  3. Click "load"
  4. Wait around for the loading to complete with an empty modal.

Expected behavior The modal should close once the loading starts, not after it finishes.

Screenshots

Screen Shot 2019-07-11 at 1 16 57 PM
doutriaux1 commented 5 years ago

we should 1- not clean until ready to close 2- add a little spinning wheel that says "loading" or something like that.

sterlingbaldwin commented 5 years ago

That sounds good. We can copy the code that William used for the PNG saving loader wheel.