search

CDAT / jupyter-vcdat

A Jupyter Lab extension based on vCDAT.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Testing update #157

Closed downiec closed 4 years ago

downiec commented 4 years ago

This pull request contains a major overhaul of the Selenium Testing suite including some new classes and functions which hopefully simplify writing new tests and are more reliable. The Firefox tests have been re-written and tests were designed to include fixes for some of the issues specifically related to Firefox. The latest master was merged and some updates to the functionality relating to the animate feature have been added. The animate feature switch state is now saved to meta-data like the other switches, and changes to how the state is maintained were included. Also the tutorial was updated to include the animation feature and the typescript files were linted and cleaned up. Also a BSD License file has been added (since it was missing), and the .circleci config file now calls the .taskfile test script to run the Selenium tests. The taskfil was updated to allow running of browser specific tests as well as installing/setting up tests for just one browser driver if desired.

sterlingbaldwin commented 4 years ago

I started to go through this, but it seems like there are still active changes. If this is a candidate for the final version of this PR let me know and I'll go through it, otherwise mark it as a draft PR.

downiec commented 4 years ago

@sterlingbaldwin @muryanto1 I finally got both Chrome AND Firefox tests to pass! This PR is ready for review. @muryanto1 I only made a few updates since you last checked my PR, the updates were specifically so that firefox tests would pass. If you'd like to review again, please do. Thanks!