search

CDAT / jupyter-vcdat

A Jupyter Lab extension based on vCDAT.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Install refactor #158

Closed downiec closed 4 years ago

downiec commented 4 years ago

This is an update to the installation process which seeks to consolidate deployment into a single source. Adds a new script: scripts/deploy_update.py which when run, will automatically update/create a corresponding Dockerfile and install_script.sh which contain the appropriate updated dependencies. The Dockerfile and install script can be further updated by modifying their corresponding templates (all located in the deploy folder). This PR also includes updates to the circleci config made by Lina, which will make circleci use the latest docker image for chrome and firefox testing. It will then use the same base image needed for CDAT and will run the install script to install vcdat to match what is installed locally. JupyterLab is pinned to version 1.2.1 for compatibility reasons. Migrating to JupyterLab 2.0 will be done in a later update.

sterlingbaldwin commented 4 years ago

Go ahead and merge this once the tests are passing.

downiec commented 4 years ago

@muryanto1 Tests are passing after I implemented your suggestions. Can you re-review and then I'll merge?