search

CDAT / vcs-js

3 stars 3 forks source link

Infrastructure update #33

Closed scottwittenburg closed 6 years ago

scottwittenburg commented 6 years ago

I think this is ready for review now :smile:

scottwittenburg commented 6 years ago

Ping @danlipsa just FYI.

scottwittenburg commented 6 years ago

Ok @danlipsa I think this is ready for you to try out. The tests are passing on Travis now, and there is documentation in the README about how you run the tests locally as well as how you can add new tests and baseline images to go with them. The current tests include some image-based ones (including one with multiple baselines), as well as one that fetches the colormap names and makes sure they're all there. We can add more as time permits.

I can iron out anything you run up against, and then once you're happy, I'd like to re-write the history before we merge this. I'd probably just go with a single giant commit with a good change description.

danlipsa commented 6 years ago

@scottwittenburg Nice. Just push the one giant commit. Then I can pull your branch and try it out.

scottwittenburg commented 6 years ago

Just a reminder @danlipsa: To test this out, you should delete your node_modules directory and then run npm install.

danlipsa commented 6 years ago

Very nice! Thanks Scott.