search

CDAT / vcs-js

3 stars 3 forks source link

WIP: Update package lock (really to trigger a test) #40

Closed scottwittenburg closed 6 years ago

scottwittenburg commented 6 years ago

Well, I wasn't expecting this to fix the issues with the master build on Travis ;-) But I suppose it can't hurt.

doutriaux1 commented 6 years ago

ooops..I saw it passes on your travis, so I thought we might as well merge it into master and cross our fingers!

scottwittenburg commented 6 years ago

Yes, fingers crossed! But I don't have high hopes...

scottwittenburg commented 6 years ago

But I guess it did pass. I hope it's not just that there's something flaky about the testing infrastructure. But the diff on that package-lock was pretty huge, it could just be that some out of date packages got installed during the master test and caused the tests to fail.

I'll try to keep an eye on Travis and make sure the master builds aren't failing. Normally I don't see that unless I go digging, whereas if my PR tests fail, I get an email and my topic can't get merged.