search

CDAT / vcs-js

3 stars 3 forks source link

Adds an 'isTime' boolean to each axis returned from cdat.file.variables #46

Closed James-Crean closed 6 years ago

James-Crean commented 6 years ago

vCDAT needs to be able to reliably determine if a given axis describes time. This simply adds a call to .isTime() and returns the value as 'isTime'.

Please let me know if there is anything else that needs to be done to make this change robust.

scottwittenburg commented 6 years ago

This looks good to me, but maybe @danlipsa knows something I don't?

The CircleCI test failure is unrelated, normally we're not testing vcs-js PRs on CircleCI, but I guess I enabled it for everyone's branches yesterday when I was looking into why recent master builds have failed there. I think it's safe to merge this.