search

CDAT / vcs-js

3 stars 3 forks source link

Make sure variable bounds are json serializable #51

Closed scottwittenburg closed 6 years ago

James-Crean commented 6 years ago

LGTM. I think @doutriaux1's input will matter more than mine in this case though.

scottwittenburg commented 6 years ago

@doutriaux1 To your comment about data possibly stored in reversed order: If we are taking the returned result in the first position to be the min, and the second position to be the max, those are still true and valid, are they not? I guess it may depend on how client code uses the results. Maybe we should be using a dictionary there so it's clear:

bounds = {
  min: float(min(lonData)),
  max: float(max(data)),
},
scottwittenburg commented 6 years ago

@doutriaux1 I guess this could be ready now.