Closed ericbuckley closed 5 months ago
@zdeveloper to add some additional context... In our dedupe check-in today, we discussed starting this process. The idea was to include the OCR team as well, as the teams are sharing this repo and will likely collaborate on future endeavors. If you prefer having two processes, one for dedupe and another for OCR, please let @bryanbritten know.
@jonchang @colekettler @arinkulshi-skylight @knguyenrise8 @alhayward @cbrinson-rise8 @derekadombek even though I didn't explicitly tag you as reviewers in this PR, I highly value your input and ideas. Therefore, if you have the time, I encourage you to read these documents and share your thoughts.
Looks great! Thanks for putting this together!
Pull Request
Description
This PR aims to initiate a discussion to standardize our code review process, with the intention of incorporating agreed-upon artifacts to provide guidance for the team in the future.
Additional Notes
The content herein is not meant to be definitive or anywhere near our team's desired outcome. Rather, it serves as an initial framework, incorporating widely-used boilerplate definitions available online, along with some insights drawn from my past team experiences.
If anyone finds this initial framework too opinionated or inflexible, please let your lead(s) know. Starting over is always an option.
The documents within are as follows:
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process:
cc @zdeveloper @jonchang @colekettler @arinkulshi-skylight @knguyenrise8 @bryanbritten @alhayward @cbrinson-rise8 @derekadombek