CDCgov / IDWA

Intelligent Data Workflow Automation

Apache License 2.0

1 stars 1 forks source link

[IDWA-OPS-58] Poetry test action for OCR #63

Closed derekadombek closed 3 months ago

derekadombek commented 3 months ago

Pull Request

Description

This will unit test as left and often as possible in CI in regards to work being done in OCR

Related Issues

58

Additional Notes

Checklist

Please review and complete the following checklist before submitting your pull request:

[x] I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
[x] I have reviewed my changes to ensure they are clear, concise, and well-documented.
[x] I have updated the documentation, if applicable.
[x] I have added or updated test cases to cover my changes, if applicable.
[x] I have minimized the number of reviewers to include only those essential for the review.
[x] I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

[ ] The code follows best practices and conventions.
[ ] The changes implement the desired functionality or fix the reported issue.
[ ] The tests cover the new changes and pass successfully.
[ ] Any potential edge cases or error scenarios have been considered.

derekadombek commented 3 months ago

LGTM! thank you! is there a way to test it before merging, I am cool with merging it and testing it afterwards, just curious

You can! but you would need to pull the branch down locally and then add branches: [idwa-OCR-58-poetry-test-action] to on: push and then push the change to trigger the workflow but yeah it running in main and pushing a new branch would be easier. Also, there were some test runs in the Actions tab.