Closed jonchang closed 3 months ago
@derekadombek ready for review, I think. It should only check in the ocr/ directory now. dedupe/ can opt in by specifying something in pyproject.toml
or ruff.toml
, though I still think we should just have one standard for the entire repository to simplify things
@derekadombek ready for review, I think. It should only check in the ocr/ directory now. dedupe/ can opt in by specifying something in
pyproject.toml
orruff.toml
, though I still think we should just have one standard for the entire repository to simplify things
I personally don't mind either way how the workflows get divided. This will work but It's usually good to keep things uniform and standard across a repo and sticking with one method of doing it.
Pull Request
Description
This implements the ruff formatter and linter for automatic style checks using github actions.
Related Issues
See https://github.com/CDCgov/IDWA/blob/main/open_practices.md#recommended-practices, configuration for linters.
Additional Notes
Line length 118 was chosen because (at least last time I checked) it is the maximum width that the github diff viewer has before soft wrapping.
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: