CDCgov / MicrobeTrace

The Visualization Multitool for Molecular Epidemiology and Bioinformatics
https://microbetrace.cdc.gov/
Apache License 2.0
88 stars 38 forks source link

ANGULAR: Color nodes and links in phylogenetic tree view #606

Open roxycintron opened 2 years ago

roxycintron commented 2 years ago

Describe the bug Nodes and links are not colored when the 'Leaves' and 'Branches' color settings are selected. However, node and link colors display correctly in the 2D network.

To Reproduce Steps to reproduce the behavior:

  1. Load fasta and node files and click Launch
  2. Select 'Phylogenetic Tree' view
  3. Click the Settings wheel and select the 'Leaves' tab
  4. Select 'Show Colors' (the Global Settings open)
  5. Select to 'Color Nodes By' Virus ID
  6. Select to 'Color Links By' Distance
  7. See error: nodes and links are not colored in the phylogenetic tree view

image

Node and link colors are working in 2D network image

Desktop (please complete the following information):

reagank commented 1 year ago

This may actually be a shortcoming in the tree library, I'm not sure that it allows coloring nodes differently by variable. I don't think this is possible in the current version of MT, either. I'll remove the option for it from the settings UI.

roxycintron commented 1 year ago

Yes, nodes are colored in the 2D network and phylogenetic tree in classic MT. I don't think links are colored in trees though.

On Wednesday, November 16, 2022, Reagan Kelly @.***> wrote:

This may actually be a shortcoming in the tree library, I'm not sure that it allows coloring nodes differently by variable. I don't think this is possible in the current version of MT, either. I'll remove the option for it from the settings UI.

— Reply to this email directly, view it on GitHub https://github.com/CDCgov/MicrobeTrace/issues/606#issuecomment-1317382991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREB3BMFHIZSDKBCSR3CPSLWIUJ6TANCNFSM6AAAAAAR2T3Z6M . You are receiving this because you authored the thread.Message ID: @.***>