search

CDCgov / MicrobeTrace

The Visualization Multitool for Molecular Epidemiology and Bioinformatics
https://microbetrace.cdc.gov/
Apache License 2.0
88 stars 38 forks source link

Link list repeats a node and builds wrong network #803

Closed ikb6 closed 2 months ago

ikb6 commented 6 months ago

This bug was emailed to me by a user. I got on a call with him, copy pasted the cells into a blank csv, saved and used it. That seemed to fix it then, but he tried doing it and that fix is not working for him. Could you check the CSV file at link below and see what could be corrupted?

Trouble sharing link- please see email for attachments

https://cdc.sharepoint.com/:x:/r/teams/nchhstp-dhap-lb-microbetrace/Shared%20Documents/General/Files%20for%20bug%20reports/Issue803_microbetrace_link_test_Nelson.csv?d=wbc45579b6b97477994810c2262cd8813&csf=1&web=1&e=HuHLqf

Wrong network

Neslson_test_link_bug.JPG

Correct network after copy pasting

Nelson_correct_network.JPG
dacowan404 commented 5 months ago

The csv file that you sent has a space before all the values in the target column. So MicrobeTrace is interpreting "AC001" and " AC001" as different node names. In the short term, he could trim function in excel to get rid of these whitespaces. When I did that I got the correct network except link be AB001 and AC003 which isn't in CSV. This is probably just a typo because link between AB001 and AC001 is in the CSV twice. I thought MicrobeTrace had this functionality to remove whitespace at start and end.

billswitzer2 commented 5 months ago

Thanks David!

From: David Cowan @.> Sent: Thursday, April 25, 2024 8:56 AM To: CDCgov/MicrobeTrace @.> Cc: Subscribed @.***> Subject: Re: [CDCgov/MicrobeTrace] Link list repeats a node and builds wrong network (Issue #803)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

The csv file that you sent has a space before all the values in the target column. So MicrobeTrace is interpreting "AC001" and " AC001" as different node names. In the short term, he could trim function in excel to get rid of these whitespaces. When I did that I got the correct network except link be AB001 and AC003 which isn't in CSV. This is probably just a typo because link between AB001 and AC001 is in the CSV twice. I thought MicrobeTrace had this functionality to remove whitespace at start and end.

— Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/MicrobeTrace/issues/803#issuecomment-2077115975, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHMTDBMO7JG5HTIGDTT33ETY7D4NDAVCNFSM6AAAAABGXSBSR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGEYTKOJXGU. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

ikb6 commented 5 months ago

Ah, great catch, thanks David!

dacowan404 commented 5 months ago

@ikb6 I have updated the angular version to trim whitespaces from node names. It is currently deployed on the mossy site, so you should be able to use the original file that was causing this bug