codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 98.03922% with 2 lines in your changes missing coverage. Please review.
Project coverage is 93.96%. Comparing base (
145ced6) to head (3206d05). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pyrenew/arrayutils.py | 0.00% | 1 Missing :warning: |
| pyrenew/deterministic/deterministic.py | 66.66% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #441 +/- ## ========================================== + Coverage 93.72% 93.96% +0.24% ========================================== Files 43 42 -1 Lines 1052 978 -74 ========================================== - Hits 986 919 -67 + Misses 66 59 -7 ``` | [Flag](https://app.codecov.io/gh/CDCgov/PyRenew/pull/441/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/CDCgov/PyRenew/pull/441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | `93.96% <98.03%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
While a large amount of work went into implementing
SampledValue, I ultimately think the codebase is better without it. We haven't been able to take advantage of it in any meaningful way, and it adds a lot of complexity and visual noise to the models. I'm open to reimplementing it (or something similar) on a subset of model components in the future, but attaching it everyRandomVariableseems unwise.