The RecordLinker is a service that links records from two datasets based on a set of common attributes. The service is designed to be used in a variety of public health contexts, such as linking patient records from different sources or linking records from different public health surveillance systems.
Simplifying database settings via one environment variable and updating test cases to use that rather than having everything hard-coded.
Additional Notes
pyway is the one exception to where the database parameters require individual values rather than a database URI. This is however deprecated functionality, as we'll be moving away from this and in favor of alembic so we can more easily support different database servers (also pyway doesn't support Microsoft SQL Server, which is what NBS uses).
Checklist
Please review and complete the following checklist before submitting your pull request:
[x] I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
[x] I have reviewed my changes to ensure they are clear, concise, and well-documented.
[x] I have updated the documentation, if applicable.
[x] I have added or updated test cases to cover my changes, if applicable.
[x] I have minimized the number of reviewers to include only those essential for the review.
[x] I have notified teammates in the review thread to build awareness.
Checklist for Reviewers
Please review and complete the following checklist during the review process:
[ ] The code follows best practices and conventions.
[ ] The changes implement the desired functionality or fix the reported issue.
[ ] The tests cover the new changes and pass successfully.
[ ] Any potential edge cases or error scenarios have been considered.
Description
Simplifying database settings via one environment variable and updating test cases to use that rather than having everything hard-coded.
Additional Notes
pyway is the one exception to where the database parameters require individual values rather than a database URI. This is however deprecated functionality, as we'll be moving away from this and in favor of alembic so we can more easily support different database servers (also pyway doesn't support Microsoft SQL Server, which is what NBS uses).
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: