search

CDCgov / Rt-without-renewal

https://cdcgov.github.io/Rt-without-renewal/
Apache License 2.0
12 stars 2 forks source link

Robustness against stochastic failure in test CI #318

Open SamuelBrand1 opened 2 weeks ago

SamuelBrand1 commented 2 weeks ago

I note that #314 got bumped from the merge queue due to an occasional stochastic failure... despite this PR not being concerned with EpiAware.

what is the best way to build resilience here without causing false pass checks? Maybe fixing the rand seed?

seabbs commented 2 weeks ago

Yes I think fixing the seed here and generally makes a lot of sense

SamuelBrand1 commented 1 week ago

It would be super convenient if we could add a line or two of code that gets propagated to every testitem. I don't think thats currently possible so I've flagged it here https://github.com/julia-vscode/TestItemRunner.jl/issues/75

seabbs commented 1 week ago

Good point. Is there really no ability to run across test setup code?

SamuelBrand1 commented 1 week ago

Looks like this is coming https://github.com/julia-vscode/TestItemRunner.jl/pull/57

AFAIK its blocked by integration into VS-code test suite.

SamuelBrand1 commented 1 week ago

Things moving here

https://github.com/julia-vscode/TestItemRunner.jl/pull/57#issuecomment-2212396718