search

CDCgov / Rt-without-renewal

https://cdcgov.github.io/Rt-without-renewal/
Apache License 2.0
17 stars 3 forks source link

Improve Zygote compatibility #339

Closed seabbs closed 2 months ago

seabbs commented 3 months ago

Benchmarking suggests that there are currently a range of issues preventing the use of a Zygote backend. It is unclear what the utility of supporting this is but if we wanted to we should investigate.

SamuelBrand1 commented 3 months ago

C&P from the PR:

Quick opinionated view. Since Zygote is a source-to-source AD it greatly benefits from custom rrules (https://github.com/JuliaDiff/ChainRulesCore.jl), my prior without a deep analysis is that to get good performance with Zygote for EpiAware we'd need to be committed to creating a system of custom rules.