CDCgov / cfa-config-generator

Apache License 2.0
0 stars 0 forks source link

Fix default workflow case #17

Closed amondal2 closed 1 month ago

amondal2 commented 1 month ago

Closes #16 --

If no inputs are supplied to the GUI, then Github sets them on the environment as empty string (idk why) -- before the workflow was failing because os.environ.get() would get the empty string and set it for all downstream variables. Now, if an empty string is set on the environment, we use the default value instead, taking advantage of the or operator, as empty strings evaluate to False: https://stackoverflow.com/a/1338532

Happy to do this another way if there are cleaner ways to handle!

amondal2 commented 1 month ago

Successful run against this branch here: https://github.com/CDCgov/cfa-config-generator/actions/runs/11556797538/job/32165320833