CDCgov / cfa-epinow2-pipeline

https://cdcgov.github.io/cfa-epinow2-pipeline/
Apache License 2.0
10 stars 2 forks source link

Adding action to post artifact #90

Closed gvegayon closed 1 month ago

gvegayon commented 1 month ago

This pull request updates the GitHub Actions workflow for building and deploying the pkgdown site. The most important changes include adding permissions for pull requests, saving artifacts, and posting artifacts to pull requests.

Enhancements to GitHub Actions workflow:

github-actions[bot] commented 1 month ago

Thank you for your contribution @zsusswein :rocket:! Your pkgdown-site is ready for download :point_right: here :point_left:! (The artifact expires on 2024-11-01T13:34:03Z. You can re-generate it by re-running the workflow here.)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

zsusswein commented 1 month ago

As part of this issue, it would be good to fix the broken bullet point rendering in the pkgdown website. It looks fine in the readme rendering, so it's a good test-case of what this can prevent in the future.

The issue has this task listed too. Is that something you'd be able to add here?

See this on the website:

image

gvegayon commented 1 month ago

I think fd5453e fixes the broken bullet. Also, the mermaid diagram is not rendering properly, but that is something I would address in a separate PR as it needs more coding.