search

CDCgov / cfa-gam-rt

R package for real-time Rt estimation with penalized splines
https://cdcgov.github.io/cfa-gam-rt/
Apache License 2.0
13 stars 1 forks source link

User feedback on input data formatting #15

Open zsusswein opened 3 months ago

zsusswein commented 3 months ago

In #13, there was some back-and-forth on whether it made sense to provide the input data via independent vectors or via a dataframe. We landed on keeping the vector-based approach as is, but @seabbs noted:

However, I don't really agree with this design decision and find the arguments in favour of it quite weak. In particular, calling out EpiEstim as having clarity in its design language seems problematic to me as people regularly complain about this to me. My particular concern is that it locks you in to having a specific set of vectors always which means if you did want to later support a formula interface etc it would be quite hard.

This issue should be resolved with some outside perspectives and user feedback after a v0.1 release is available.

zsusswein commented 4 days ago

I'm punting this to v0.3. I want to have a little more functionality in place before user testing.

seabbs commented 3 days ago

Good idea. I like the idea of a rough and ready getting started that shows the current pain points and pointing users to that (that is what we have gone for in epidist).