CDCgov / dibbs-query-connector

A FHIR client allowing public health agencies to query health care organizations directly or via a TEFCA QHIN
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

condition template selection page #119

Closed fzhao99 closed 1 month ago

fzhao99 commented 1 month ago

PULL REQUEST

Summary

Part two that builds the actual page.

For now, I've put this page at /queryBuilding/buildFromTemplate, but worth a larger convo around when we use the Next router for URL-based rendering and when we handle things in a more SPA fashion like we do with the query search flow.

For design

Related Issue

Fixes #75

Checklist

linear[bot] commented 1 month ago

QUE-32 Build in condition template selection page

fzhao99 commented 1 month ago
  • at least on the figma Back to My Queries isn't underlined

@mikang it looks like the other backlinks in the query customization flow are underlined, so let us know if this one should be too.

mikang commented 1 month ago

The search is beautiful @fzhao99 — I think it deserves its own GH comment

mikang commented 1 month ago

Here is my feedback! https://docs.google.com/document/d/1gMX9AMwk1KAnuN2e8_cvlaMg1kbNQOac86mE5cBVg28/edit?usp=sharing

mikang commented 1 month ago

looks good to me. only minor quibbles

  • at least on the figma Back to My Queries isn't underlined
  • there isn't the Demo alert at the top of the page. that might be just because the page is not connected to stuff currently, as i write this..carry on!

hmm true about the underline. I didn't notice that on the other pages. Is it possible to remove the underline from all backlinks that have an arrow? The underline is good for accessibility to show that it's clickable, but considering there is an arrow, I'm not concerned about it not seeming clickable