Closed fzhao99 closed 1 week ago
- at least on the figma Back to My Queries isn't underlined
@mikang it looks like the other backlinks in the query customization flow are underlined, so let us know if this one should be too.
The search is beautiful @fzhao99 — I think it deserves its own GH comment
looks good to me. only minor quibbles
- at least on the figma Back to My Queries isn't underlined
- there isn't the Demo alert at the top of the page. that might be just because the page is not connected to stuff currently, as i write this..carry on!
hmm true about the underline. I didn't notice that on the other pages. Is it possible to remove the underline from all backlinks that have an arrow? The underline is good for accessibility to show that it's clickable, but considering there is an arrow, I'm not concerned about it not seeming clickable
PULL REQUEST
Summary
Part two that builds the actual page.
For now, I've put this page at
/queryBuilding/buildFromTemplate
, but worth a larger convo around when we use the Next router for URL-based rendering and when we handle things in a more SPA fashion like we do with the query search flow.For design
queryBuilding/buildFromTemplate
. The page is read-only for now (ie the "create query" button doesn't do / redirect to anything and the query name field also doesn't do anything). "Writing" this info and updating the relevant pages are forthcomingRelated Issue
Fixes #75
Checklist