CDCgov / dibbs-query-connector

A FHIR client allowing public health agencies to query health care organizations directly or via a TEFCA QHIN
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

align customize query flow to design #25

Closed fzhao99 closed 1 month ago

fzhao99 commented 1 month ago

PULL REQUEST

Apologies for the large PR!

Summary

Breaks the query flow into the intended four step process by

Related Issue

After all the demo v0 pages are implemented independently, ensure that the pages link to one another according to the user flow that Michelle put together

Fixes #2663

Acceptance Criteria

For design

@mikang

DanPaseltiner commented 1 month ago

Noting that the "customize query" selection state will only maintain itself within the select query page despite what we talked about in Slack. Getting it to persist longer will be kinda complicated, so I didn't want it to block this work. Can have a followup ticket if we want to add that.

@fzhao99 persisting beyond the scope of the query at hand is beyond what we are hoping to do at this point. Next sprint we will begin tackling query building which will give users the ability to create and edit their queries not just the 6 we currently offer out of the box. Long way of saying you are totally right, but this limitation is fine for now.

DanPaseltiner commented 1 month ago

I think we need to change the copy here

image

As users will have already provided demographic data by this point. We could address in a separate ticket though.

@fzhao99 @mikang

mikang commented 1 month ago

I think we need to change the copy here

image

As users will have already provided demographic data by this point. We could address in a separate ticket though.

@fzhao99 @mikang

Good catch @DanPaseltiner

I think we can remove the supporting text and have just the bold text that says "Query customization successful." Thoughts?

mikang commented 1 month ago

Update for visibility — Bob and I paired live, so all good to go from the design side once those changes are made! Mainly spacing