CDCgov / dibbs-query-connector

A FHIR client allowing public health agencies to query health care organizations directly or via a TEFCA QHIN

Creative Commons Zero v1.0 Universal

4 stars 0 forks source link

Adding loading step to customize query selection #48

Closed robertandremitchell closed 4 weeks ago

robertandremitchell commented 4 weeks ago

PULL REQUEST

Summary

This adds a loading step to the customize query step to prevent from getting ahead of the db load.

I think the only other open questions I had:

do we want the customize query button unclickable until an actual selection is made? If you click the button, it just takes you to a blank version of the page, which could be a little confusing if the user does think they made a selection.
is Social Determinants of Health supposed to be broken? Getting this error: No results found for query: Social Determinants of Health

I can open up a ticket to look more closely at it, but I wasn't sure if this was a known bug or if anyone knew offhand why it may now be broken.

Related Issue

Fixes #47

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review

ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”

Additional Information

Anything else the review team should know?

Checklist

[ ] If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

robertandremitchell commented 4 weeks ago

made some follow-up tickets: