This PR adds a new docker-compose-e2e-tests.yaml that spins up a local HAPI FHIR server and loads the Hyper Unlucky patient into the server. I chose to add a new dock compose file to prevent the primary, docker compose file from requiring HAPI, which is only used for e2e tests, but open to hearing others' ideas.
I also updated the e2e tests to manually select the local instance of the HAPI server, which is now available in the drop down.
Some lessons learned:
Our flaky issues stemmed from the Public HAPI server, which we thought was the issue, but it was nice to get additional confirmation. We should probably continue to make sure our e2e tests remain divorced from external services.
We did not end up needing to use networks or the container names when connecting between containers either locally or in github actions. The only place where the container name is used instead of localhost is in fhir_servers.
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review
ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”
Additional Information
Checklist
[ ] If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)
PULL REQUEST
Summary
This PR adds a new
docker-compose-e2e-tests.yamlthat spins up a local HAPI FHIR server and loads the Hyper Unlucky patient into the server. I chose to add a new dock compose file to prevent the primary,docker composefile from requiring HAPI, which is only used for e2e tests, but open to hearing others' ideas.I also updated the e2e tests to manually select the local instance of the HAPI server, which is now available in the drop down.
Some lessons learned:
fhir_servers.Related Issue
Fixes # phdi 2758
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review
Additional Information
Checklist