search

CDCgov / multisignal-epi-inference

Python package for statistical inference and forecast of epi models using multiple signals
https://cdcgov.github.io/multisignal-epi-inference/
10 stars 1 forks source link

Renaming sample_infections to compute_future_infections #137

Closed gvegayon closed 1 month ago

gvegayon commented 1 month ago

Renames functions to avoid suggesting stochasticity.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.24%. Comparing base (4dd40bb) to head (72fec94). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ======================================= Coverage 92.24% 92.24% ======================================= Files 34 34 Lines 683 683 ======================================= Hits 630 630 Misses 53 53 ``` | [Flag](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/137/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/137/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | `92.24% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gvegayon commented 1 month ago

I know the main issue suggested compute_future_infections but on review I might suggest

compute_infections_from_rt and compute_infections_from_rt_with_feedback

Thoughts @gvegayon @damonbayer ?

I like that better. Updating