search

CDCgov / multisignal-epi-inference

Python package for statistical inference and forecast of epi models using multiple signals
https://cdcgov.github.io/multisignal-epi-inference/
10 stars 1 forks source link

Standardize output length for functions that yield sequences/timeseries #142

Closed dylanhmorris closed 4 weeks ago

dylanhmorris commented 1 month ago

A number of array creation functions (deterministic or stochastic) exist in the project. I think we should standardize on any timeseries/sequence sample(duration=n) or compute(duration=n) call:

  • returning an array (which I'll call $y(t)$ ) of exactly length n.
  • If $x \ge 1$ initial values are provided, including them as the first $x \le$ n entries in $y(t)$

_Originally posted by @dylanhmorris in https://github.com/CDCgov/multisignal-epi-inference/pull/131#discussion_r1621392498_

dylanhmorris commented 1 month ago

@gvegayon @damonbayer @AFg6K7h4fhy2 for visibility? Thoughts on this proposed standard or counterproposals?

gvegayon commented 1 month ago

#143 #144 (to be merged into #131) addresses this.

gvegayon commented 4 weeks ago

The main PR dealing with this was merged. Closing.