CDCgov / multisignal-epi-inference

Python package for statistical inference and forecast of epi models using multiple signals
https://cdcgov.github.io/multisignal-epi-inference/
10 stars 1 forks source link

All processes return tuple(array) with array length equal to . #144

Closed gvegayon closed 4 weeks ago

gvegayon commented 1 month ago

(This is the right PR :P)

This addresses and should close #142. The PR does the following:

Notice this PR will be merged in to #131.

cc @damonbayer and @dylanhmorris

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (439367c) to head (e6d75dc).

Files Patch % Lines
...odel/src/pyrenew/model/rtinfectionsrenewalmodel.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 8-state-level-unadjusted-rt #144 +/- ## =============================================================== + Coverage 92.48% 92.63% +0.14% =============================================================== Files 34 34 Lines 719 733 +14 =============================================================== + Hits 665 679 +14 Misses 54 54 ``` | [Flag](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/144/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | `92.63% <93.33%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gvegayon commented 4 weeks ago

Codecov is now happy, @damonbayer and @dylanhmorris

damonbayer commented 4 weeks ago

Codecov is now happy, @damonbayer and @dylanhmorris

I think the tests I added are now redundant.

gvegayon commented 4 weeks ago

No redundant tests now, @dylanhmorris and @damonbayer.

damonbayer commented 4 weeks ago

Pinging @dylanhmorris for final review.