Closed dylanhmorris closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.78%. Comparing base (
48b7471
) to head (b5178a6
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should we check the size/shape/type of inputs?
@damonbayer are you talking about checking the inputs to the factories or about having the functions they produce/return perform input checks?
@damonbayer are you talking about checking the inputs to the factories or about having the functions they produce/return perform input checks?
Checking inputs to factories so we can provide useful errors.
Things that occur to me:
dists
are ArrayLike
and the transforms are callable.dists
are of the same length (in the future, we might want to have the double scanner just use history subsets of the length of the longer array, and automagically sub-subset when taking the dot product with the shorter array, but that feels a bit implicit.Stricter stuff that I'm more reluctant to implement:
jax
arrays, but that's a bit tricky.Anything else you had in mind @damonbayer?
@dylanhmorris Sounds good to me.
Ready for review.
This PR:
new_double_scanner
tonew_double_convolve_scanner
for consistency.new_convolve_scanner
Out of scope
logistic_susceptibility_adjustment
)177