Closed AFg6K7h4fhy2 closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.76%. Comparing base (
81c49f1
) to head (c62b7ab
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@damonbayer I agree with you that a one sentence description can help. I still believe that having the repository structure displayed in the README would be a net good (perhaps if a Last Updated: YYYY-MM-DD) if provided somewhere. I am fine with this somewhere being the developer documentation while leaving a note on how to display the structure for oneself, as you suggested.
Is this
I think the model equation sheet could be moved to the documentation along with a brief introduction to the renewal model.
expected to be covered in #191 ?
@sbidari
Is this
I think the model equation sheet could be moved to the documentation along with a brief introduction to the renewal model.
expected to be covered in #191 ?
@sbidari
Yes, just requested review for some proposed changes in documentation.
@damonbayer I agree with you that a one sentence description can help. I still believe that having the repository structure displayed in the README would be a net good (perhaps if a Last Updated: YYYY-MM-DD) if provided somewhere. I am fine with this somewhere being the developer documentation while leaving a note on how to display the structure for oneself, as you suggested.
I think it would be more helpful to give some general description (perhaps spread among readme.md
, pipeline/readme.md
, model/readme.md
, and the dev documentation) of the structure.
For example in the present readme, we already say
The library and pipeline are located in the model/ and pipeline/ directories of the GitHub repository, respectively.
That is enough info to get someone headed down the right path. Then in model/readme.md
, we could say something like "the package is split up among x sub-modules". But this is already evident from the "reference" section of the website, so I'm not sure it's that helpful.
Printing the tree doesn't provide a lot of insight, and it is likely to often be out of date/annoying to maintain.
This is a small pull request that adds two simple items to the README file: the structure of the MSR repository via
tree
and a Resources section.A Repository Structure section enables users to get an impression of the MSR repository very quickly. While MSR's structure will change, requiring the Repository Structure section of the README to be manually revised, revisions need not be done frequently, since the design of MSR currently is such that further updates are unlikely to deviate significantly enough for the existing but outdated
tree
output to cease to be useful. The only request I have here for reviewers is to provide some thoughts for what to ignore when runningtree
.Resources are helpful for newcomers and for those who've forgotten where to find particular items relevant to the project. I have added four resources. More resources can be added by others, including the reviewers.
As for the placement of the sections in the README, I thought that after the General Disclaimer worked well, since Public Domain Standard Notice becomes less MSR and or CDC specific.