search

CDCgov / multisignal-epi-inference

Python package for statistical inference and forecast of epi models using multiple signals
https://cdcgov.github.io/multisignal-epi-inference/
9 stars 1 forks source link

Remove default name arguments for NumPyro sites from non-model classes #198

Open damonbayer opened 1 week ago

damonbayer commented 1 week ago

Some code has default names for NumPyro sites baked in.

Ex:

https://github.com/CDCgov/multisignal-epi-inference/blob/428bcc4f3ba4840d8209653ecbc285702141c209/model/src/pyrenew/observation/negativebinomial.py#L17-L23

This could lead to problems if there are multiple random variables constructed from the same class. At this low level, we should require users to specify the site names.

dylanhmorris commented 1 week ago

I agree with this.