search

CDCgov / multisignal-epi-inference

Python package for statistical inference and forecast of epi models using multiple signals
https://cdcgov.github.io/multisignal-epi-inference/
9 stars 1 forks source link

Adding `t_start` and `t_unit` #217

Open gvegayon opened 4 days ago

gvegayon commented 4 days ago

This PR does what #215 lists. Important to note is that the new tutorial sets some design considerations that will be useful for implementing the methods needed to deal with time in the model.

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.58%. Comparing base (4f20336) to head (35faf3b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #217 +/- ## ========================================== + Coverage 92.47% 92.58% +0.10% ========================================== Files 40 40 Lines 877 890 +13 ========================================== + Hits 811 824 +13 Misses 66 66 ``` | [Flag](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/217/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/217/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | `92.58% <100.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gvegayon commented 3 days ago

Largely agreeing with @dylanhmorris's comments. Also wanted to say that I would be open to shorter names, since these will be referenced so often. Some ideas: time_start/unit, ts_start/unit, or t_start/unit.

Agree, at some point I was using ts_start/ts_unit. Will return there!

dylanhmorris commented 3 days ago

I think the s is superfluous; I vote for t_start/unit