Open damonbayer opened 4 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.59%. Comparing base (
84f7809
) to head (3341103
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The visualizations leave a lot to be desired. I'm hoping @sbidari could maybe work on them as our resident ArviZ expert. In particular, I think the use of Highest posterior density intervals make the results look worse than they are. As far as I can tell, there is no way to make a plot with equal tail intervals in ArviZ, which would be surprising, if true.
I don't think there is a built in eti_plot
feature in ArviZ. We can obtain equal tail intervals using stat_focus="median"
(see here). Passing these eti intervals in place of hdi intervals in plot_hdi
should work although it's a bit hacky solution
Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
Being annoying but unless a new issue is made this should probably be addressed here. From a skim it looks mostly like exception handling.
Very exciting to get this functionality in place!
@seabbs Sorry, this PR is a bit of a mess. Converting to draft to indicate that is not ready for a full review. Just wanted to get some early feedback.
No worries at all! I'm just being an annoying GitHub 👻 today!
Adds
posterior_predictive()
andprior_predictive()
methods to model class. See model/docs/example_with_datasets.qmd for a demonstration of theposterior_predictive
function. I don't love the interface, but I think it's the best we can do, based on how numpyro works. I'm also not sure the best way to handle the documentation, since they are just thin wrappers around numpyro functions.The visualizations leave a lot to be desired. I'm hoping @sbidari could maybe work on them as our resident ArviZ expert. In particular, I think the use of Highest posterior density intervals make the results look worse than they are. As far as I can tell, there is no way to make a plot with equal tail intervals in ArviZ, which would be surprising, if true.I kind of think this PR could just be creating the methods and a separate PR could be dedicated to visualizations.Visualization to be addressed in https://github.com/CDCgov/multisignal-epi-inference/issues/221.
Closes https://github.com/CDCgov/multisignal-epi-inference/issues/202.