search

CDCgov / multisignal-epi-inference

Python package for statistical inference and forecast of epi models using multiple signals
https://cdcgov.github.io/multisignal-epi-inference/
9 stars 1 forks source link

Update tutorials formatting #220

Closed damonbayer closed 3 days ago

damonbayer commented 3 days ago

See https://github.com/CDCgov/multisignal-epi-inference/issues/159.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.47%. Comparing base (5748007) to head (3d7cc5f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #220 +/- ## ======================================= Coverage 92.47% 92.47% ======================================= Files 40 40 Lines 877 877 ======================================= Hits 811 811 Misses 66 66 ``` | [Flag](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/220/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/CDCgov/multisignal-epi-inference/pull/220/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov) | `92.47% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CDCgov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dylanhmorris commented 3 days ago

Confirming this does not (and is not intended to) close #159, correct? It does the formatting, but doesn't set it up in pre-commit, yes?

damonbayer commented 3 days ago

@dylanhmorris That's correct. I only linked to https://github.com/CDCgov/multisignal-epi-inference/issues/159 to explain why it was not done automatically.

sbidari commented 3 days ago

I am confused. Is this formatting done automatically, or no? @damonbayer @dylanhmorris

damonbayer commented 3 days ago

It can be done semi-automatically in VS Code. However, it only works on a cell-by-cell basis, so you have to go through each cell and issue a formatting command (or re-save the file if you have format on save enabled). This is what I did to create the changes in this PR.

As far as I know, there is no way to format an entire qmd at once, but that would be really nice to have in pre-commit.

damonbayer commented 3 days ago

Anyone willing to approve this @dylanhmorris @sbidari @AFg6K7h4fhy2 ?